Skip to content

QueueMovies Endpoint#38

Merged
nabobalis merged 23 commits intoHelioviewer-Project:mainfrom
akash5100:movies
Aug 4, 2022
Merged

QueueMovies Endpoint#38
nabobalis merged 23 commits intoHelioviewer-Project:mainfrom
akash5100:movies

Conversation

@akash5100
Copy link
Collaborator

@akash5100 akash5100 changed the title Movies QueueMovies Endpoint Jul 13, 2022
@akash5100 akash5100 marked this pull request as draft July 14, 2022 05:15
@nabobalis
Copy link
Member

Can this be rebased as well?

@akash5100
Copy link
Collaborator Author

akash5100 commented Jul 15, 2022

Can this be rebased as well?

Should we leave this PR draft until we close the BASEURL issue. After solving that we can rebase it with main?

@nabobalis
Copy link
Member

@akash5100

Can this be rebased as well?

We should leave this PR draft until we close the BASEURL issue. After solving that we can rebase it with main.

Just because this is a draft PR, does not mean we shouldn't rebase this.

@akash5100
Copy link
Collaborator Author

akash5100 commented Aug 2, 2022

Oops! I did a rebase but I think I messed up something.
The files I didn't changed is showing up in files changed.

@akash5100 akash5100 marked this pull request as ready for review August 2, 2022 10:13
@nabobalis
Copy link
Member

nabobalis commented Aug 2, 2022

Oops! I did a rebase but I think I messed up something. The files I didn't changed is showing up in files changed.

You want to make sure what you doing a rebase on is up to date using git remote update, you will want to try git rebase -i upstream/main, if you see extra commits that aren't part of the original PR, you will need to drop them manually

@akash5100
Copy link
Collaborator Author

Oops! I did a rebase but I think I messed up something. The files I didn't changed is showing up in files changed.

You want to make sure what you doing a rebase on is up to date using git remote update, you will want to try git rebase -i upstream/main, if you see extra commits that aren't part of the original PR, you will need to drop them manually

Thanks, can you make a review?

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #38 (2cbe718) into main (5c4bb4b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        16    +1     
  Lines          242       285   +43     
=========================================
+ Hits           242       285   +43     
Impacted Files Coverage Δ
hvpy/api_groups/movies/queue_movie.py 100.00% <100.00%> (ø)
hvpy/facade.py 100.00% <100.00%> (ø)
hvpy/parameters.py 100.00% <100.00%> (ø)
hvpy/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4bb4b...2cbe718. Read the comment docs.

@nabobalis nabobalis merged commit ce5ec27 into Helioviewer-Project:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Movies - queueMovies endpoint

4 participants

Comments